[ACR] add breaking change message#9659
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| acr export-pipeline create | cmd acr export-pipeline create added property deprecate_info_target |
||
| acr import-pipeline create | cmd acr import-pipeline create added property deprecate_info_target |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull request overview
Adds Azure CLI “breaking change” announcements to the acrtransfer extension for upcoming required parameters on pipeline create commands, along with a new scenario test and version bump.
Changes:
- Register breaking change announcements for
acr export-pipeline createandacr import-pipeline createregarding the upcoming required--storage-access-modeparameter. - Bump
acrtransferextension version to1.1.1b1and add release note entry. - Add a scenario test + recording for
acr import-pipeline listand clean up an empty/placeholder test file.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/acrtransfer/setup.py | Bumps extension version to 1.1.1b1. |
| src/acrtransfer/HISTORY.rst | Adds release notes for the breaking change announcement. |
| src/acrtransfer/azext_acrtransfer/_breaking_change.py | Registers breaking change notifications for pipeline create commands. |
| src/acrtransfer/azext_acrtransfer/init.py | Imports breaking change module to trigger registration. |
| src/acrtransfer/azext_acrtransfer/tests/init.py | Adds test package initializer. |
| src/acrtransfer/azext_acrtransfer/tests/latest/init.py | Adds latest tests package initializer. |
| src/acrtransfer/azext_acrtransfer/tests/latest/test_acrtransfer_scenario.py | Adds scenario test covering acr import-pipeline list. |
| src/acrtransfer/azext_acrtransfer/tests/latest/test_acrtransfer_scenario | Removes placeholder/empty test artifact. |
| src/acrtransfer/azext_acrtransfer/tests/latest/recordings/test_acrtransfer_import_pipeline_list.yaml | Adds recording for the new scenario test. |
src/acrtransfer/azext_acrtransfer/tests/latest/test_acrtransfer_scenario.py
Outdated
Show resolved
Hide resolved
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
/azp run |
|
Commenter does not have sufficient privileges for PR 9659 in repo Azure/azure-cli-extensions |
|
@yonzhan can you help me trigger the CI |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@yanzhudd the test says that I've modified index.json but i havent. Is there anyway to fix this 
|
|
@yanzhudd can i get help for this |
|
@yonzhan can i please get some help on this. The test says I edited index.json but I dont have any changes to index.json in my PR |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@necusjz can I get an approval now that the tests passed |
|
[Release] Update index.json for extension [ acrtransfer-1.1.1b1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=157008843&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.